p2p/discover: fix ENR filtering #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatusKysel
force-pushed
the
fix-discovery
branch
2 times, most recently
from
c276c8f to
d54be9f
Compare
|
may merge to develop branch now. |
MatusKysel
force-pushed
the
fix-discovery
branch
from
d54be9f to
106c31a
Compare
MatusKysel
changed the base branch from
merge_geth_v1.13.15_v1.14.11
to
develop
|
[email protected] سلام |
|
0x08Dc6385204D434f0A407902eF6A271de0366912 |
buddh0
reviewed
Nov 28, 2024
p2p/discover/table.go
Outdated
| @@ -493,15 +490,15 @@ func (tab *Table) bucketAtDistance(d int) *bucket { | |||
| } | |||
|
|
|||
| //nolint:unused | |||
buddh0
previously approved these changes
Nov 28, 2024
|
this is the previous PR: #1320, for reference |
zzzckck
reviewed
Nov 28, 2024
p2p/discover/table.go
Outdated
| tab.mutex.Unlock() | ||
| tab.addNodeHandled <- ok | ||
| go func() { | ||
| tab.addNodeHandled <- tab.handleAddNode(op) |
There was a problem hiding this comment.
won't it be blocked? as there is no consumer for this channel
zzzckck
reviewed
Nov 28, 2024
buddh0
approved these changes
Nov 29, 2024
zzzckck
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reintroducing ENR filtering back. This allows discv4 ENR filtering and add small support for discv5 that could be enabled later on based on testing.